search

solana-playground / solana-playground

Quickly develop, deploy and test Solana programs from browsers
https://beta.solpg.io
Apache License 2.0
398 stars 133 forks source link

Allow pasting into fields in test UI #189

Closed mcintyre94 closed 3 months ago

mcintyre94 commented 3 months ago

I'm not 100% about this fix, I might be missing some nuance about how search bar items work

But the reason pasting was not working is because item.value ||= clipboardText was never updating, because item.value was truthy:

Screenshot 2024-01-25 at 10 13 24

This PR changes it to always replace item.value with the pasted text

An alternative fix would be to remove the {current: true} from the Custom item, so that item.value is just whatever that field contains, but I'm not sure what that represents/would do. Actually I guess that wouldn't work because then you couldn't paste unless the field was empty. I'm not sure if there are circumstances where we shouldn't change item.value on paste though.

Fixes #188

mcintyre94 commented 3 months ago

Gotcha thanks, fix looks good! :)