search

solana-program / create-solana-program

pnpm create solana-program
Apache License 2.0
70 stars 9 forks source link

Use `lint` toolchain in program lint script #83

Closed buffalojoec closed 1 month ago

buffalojoec commented 1 month ago

Problem

The program lint script at scripts/program/lint.mjs is using the toolchain for format instead of lint.

Summary of Changes

Update it to use lint!

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: df6c4175870da8cabff8bb28cd69b89f460369b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------------- | ----- | | create-solana-program | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

lorisleiva commented 1 month ago

Ah well spotted!

I've noticed there's the same issue with pnpm clients:rust:lint in this line: https://github.com/solana-program/create-solana-program/blob/main/template/clients/rust/scripts/client/lint-rust.mjs#L15

Would you mind adding this to your PR? And also adding a changeset by running changeset locally.

buffalojoec commented 1 month ago

Done!