solanum-ircd / solanum

An IRCd for unified networks
https://solanum.chat/
GNU General Public License v2.0
225 stars 54 forks source link

Server advertised TLS capability on connect when SSL support has been built but not enabled #403

Closed shadowcat-mst closed 6 months ago

shadowcat-mst commented 1 year ago

I've got a fresh solanum install which has SSL support -built- but because I had to deploy it unfortunately quickly I've not set it up yet - no cert file, ssld count configured to 0 - but it still advertises the tls cap on connect which makes irssi try to STARTTLS and barf.

This can be worked around by setting -disallow_starttls on the irssi config server entry which is working fine for the user I snarfed the below log from, but given the startup ircd.log entries make it clear the solanum Has Noticed it isn't configured such that it can do SSL currently, I don't think the cap entry should be there?

(log of what happens without -disallow_starttls follows)

[scsys] !francis.scsys.co.uk *** Looking up your hostname...
[scsys] !francis.scsys.co.uk *** Found your hostname: [redacted]
[scsys] !francis.scsys.co.uk *** No Ident response
-!- Irssi: (default) warning [scsys] Now attempting STARTTLS
[scsys] -!- Capabilities supported: account-notify away-notify chghost 
    extended-join multi-prefix sasl tls userhost-in-names account-tag 
    cap-notify echo-message server-time
[scsys] -!- TLS is not configured
[scsys] -!- ERROR Closing Link: 127.0.0.1 (Connection timed out)
[scsys] -!- Irssi: Connection lost to irc.shadowcat.co.uk