Fix WHOIS reply not respecting a lack of the multi-prefix capability

solanum-ircd / solanum

An IRCd for unified networks

https://solanum.chat/

GNU General Public License v2.0

216 stars 53 forks source link

Fix WHOIS reply not respecting a lack of the multi-prefix capability #430

Closed JustAnotherArchivist closed 3 weeks ago

JustAnotherArchivist commented 3 weeks ago

Prior to this commit, RPL_WHOISCHANNELS always contained all channel membership prefixes, even when the client had not enabled the multi-prefix capability. This behaviour predates available commit history. Other ircds only return the highest prefix, as prescribed by the RFCs.

(Thanks to @fireonlive for helping me test this!)

aaronmdjones commented 3 weeks ago

Unfortunately I have had to revert this due to reasons explained in commit 746ced2308f606ddaa2781ada5eac4e4364b8f3f

JustAnotherArchivist commented 3 weeks ago

Ah, that's unfortunate. I'll open an issue for tracking this instead.