search

solar-engine / common-chicken-runtime-engine

The CCRE is Team 1540's powerful open-source robot code framework, primarily for FIRST Robotics Competition robots.
GNU Lesser General Public License v3.0
24 stars 4 forks source link

Add PWM support for unsupported controllers #164

Closed celskeggs closed 8 years ago

celskeggs commented 8 years ago

Add support for Talon SRX (over PWM), Spark, SD540, and Jaguar SP.

I really should have remembered this earlier.

amackworth commented 8 years ago

Hmm...this may be outside of the scope of this PR, but the duplication of all the FRC.[motor type]() methods bugs me. Seems to me it might be possible to abstract some of that away eventually?

amackworth commented 8 years ago

(Otherwise, this looks ready to merge. :+1:)

celskeggs commented 8 years ago

It bugs me too. However, you know how Java works, and it's hard to get around. It's important for the perceived usability of the project to be able to write something as simple as FRC.talon(5) and have it work.

amackworth commented 8 years ago

Oh, agreed! I just meant the duplication of the internals.

celskeggs commented 8 years ago

Oh yeah. Feel free to file a bug report.

amackworth commented 8 years ago

Will do!

:sparkles: mergin' :sparkles: