Closed thomascorthals closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.05
:tada:
Comparison is base (
be762b8
) 97.43% compared to head (450e309
) 97.49%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The example assumes
null
is possible, but theValueGroupResult()
constructor doesn't allow it to be nullable in the method signature.https://github.com/solariumphp/solarium/blob/be762b8db6d75529d967394fbd78a2464989540e/examples/7.7.1-plugin-minimumscorefilter-grouping.php#L38-L39
Since the example happens to select only documents with a value for the field, it doesn't actually deal with
null
values. With a query that does yield anull
group value, you get a Fatal Error.