codecov[bot]
commented
1 year ago Codecov Report
Patch and project coverage have no change.
Comparison is base (
c61a0d5) 97.49% compared to head (84e83b0) 97.49%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1084 +/- ## ======================================= Coverage 97.49% 97.49% ======================================= Files 389 389 Lines 10142 10142 ======================================= Hits 9888 9888 Misses 254 254 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `97.49% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solariumphp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/solariumphp/solarium/pull/1084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solariumphp) | Coverage Δ | | |---|---|---| | [src/Plugin/Loadbalancer/Loadbalancer.php](https://app.codecov.io/gh/solariumphp/solarium/pull/1084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solariumphp#diff-c3JjL1BsdWdpbi9Mb2FkYmFsYW5jZXIvTG9hZGJhbGFuY2VyLnBocA==) | `100.00% <ø> (ø)` | |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Both
UpdateandExtractqueries cause updates of the index, making this line in the documentation ambiguous.https://github.com/solariumphp/solarium/blob/c61a0d5815e023c4d4bfd6b7d293e9a1e7c322a9/docs/plugins.md?plain=1#L275
It makes sense to block
Extractqueries by default too. It's less harmful to have anextractOnly=truequery not load balanced than having a document indexed against sometimes-not-the-master depending on random chance.