solariumphp / solarium

PHP Solr client library
Other
932 stars 301 forks source link

: self typehints #1087

Closed thomascorthals closed 1 year ago

thomascorthals commented 1 year ago

No longer supporting PHP 7.3 means we can take advantage of the full covariance support that was introduced in PHP 7.4 and make consistent use of : self.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b1fa2ae) 97.49% compared to head (672214c) 97.49%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1087 +/- ## ======================================= Coverage 97.49% 97.49% ======================================= Files 389 389 Lines 10130 10130 ======================================= Hits 9876 9876 Misses 254 254 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `97.49% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solariumphp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/solariumphp/solarium/pull/1087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solariumphp) | Coverage Δ | | |---|---|---| | [src/Component/Grouping.php](https://app.codecov.io/gh/solariumphp/solarium/pull/1087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solariumphp#diff-c3JjL0NvbXBvbmVudC9Hcm91cGluZy5waHA=) | `100.00% <ø> (ø)` | | | [src/Component/QueryElevation.php](https://app.codecov.io/gh/solariumphp/solarium/pull/1087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solariumphp#diff-c3JjL0NvbXBvbmVudC9RdWVyeUVsZXZhdGlvbi5waHA=) | `100.00% <ø> (ø)` | | | [src/Component/ReRankQuery.php](https://app.codecov.io/gh/solariumphp/solarium/pull/1087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solariumphp#diff-c3JjL0NvbXBvbmVudC9SZVJhbmtRdWVyeS5waHA=) | `100.00% <ø> (ø)` | | | [src/Component/Result/Debug/Detail.php](https://app.codecov.io/gh/solariumphp/solarium/pull/1087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solariumphp#diff-c3JjL0NvbXBvbmVudC9SZXN1bHQvRGVidWcvRGV0YWlsLnBocA==) | `100.00% <ø> (ø)` | | | [src/Core/Event/PreCreateRequest.php](https://app.codecov.io/gh/solariumphp/solarium/pull/1087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solariumphp#diff-c3JjL0NvcmUvRXZlbnQvUHJlQ3JlYXRlUmVxdWVzdC5waHA=) | `100.00% <ø> (ø)` | | | [src/QueryType/Extract/Query.php](https://app.codecov.io/gh/solariumphp/solarium/pull/1087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solariumphp#diff-c3JjL1F1ZXJ5VHlwZS9FeHRyYWN0L1F1ZXJ5LnBocA==) | `100.00% <ø> (ø)` | | | [src/QueryType/Luke/Query.php](https://app.codecov.io/gh/solariumphp/solarium/pull/1087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solariumphp#diff-c3JjL1F1ZXJ5VHlwZS9MdWtlL1F1ZXJ5LnBocA==) | `100.00% <ø> (ø)` | | | [src/QueryType/Luke/Result/Doc/DocFieldInfo.php](https://app.codecov.io/gh/solariumphp/solarium/pull/1087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solariumphp#diff-c3JjL1F1ZXJ5VHlwZS9MdWtlL1Jlc3VsdC9Eb2MvRG9jRmllbGRJbmZvLnBocA==) | `100.00% <ø> (ø)` | | | [src/QueryType/Luke/Result/Doc/DocInfo.php](https://app.codecov.io/gh/solariumphp/solarium/pull/1087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solariumphp#diff-c3JjL1F1ZXJ5VHlwZS9MdWtlL1Jlc3VsdC9Eb2MvRG9jSW5mby5waHA=) | `100.00% <ø> (ø)` | | | [src/QueryType/Luke/Result/Fields/FieldInfo.php](https://app.codecov.io/gh/solariumphp/solarium/pull/1087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solariumphp#diff-c3JjL1F1ZXJ5VHlwZS9MdWtlL1Jlc3VsdC9GaWVsZHMvRmllbGRJbmZvLnBocA==) | `100.00% <ø> (ø)` | | | ... and [55 more](https://app.codecov.io/gh/solariumphp/solarium/pull/1087?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=solariumphp) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.