search

solariumphp / solarium

PHP Solr client library
Other
933 stars 302 forks source link

analytics component #727

Closed wickedOne closed 4 years ago

wickedOne commented 4 years ago

by the end of this year i intend to start writing an integration for solr's analytics component.

ideally this component gets integrated into solarium, but as the analytics request handler is not enabled by default, i wonder whether that's the way to go or that writing an extension would make more sense.

the way i'm curretly looking at it, is that it will be a rather straightforward component which allows setting functions, expressions and groupings.

seperately i'm considerig wiriting a query builder to ease the writing of those functions, expresions and groupigs.

what are your thoughts on this one, any suggestions or concerns?

mkalkbrenner commented 4 years ago

ideally this component gets integrated into solarium, but as the analytics request handler is not enabled by default, i wonder whether that's the way to go or that writing an extension would make more sense.

The other request handler aren't enabled by default as well. Their naming and feature set just follows the best practices. Therefore I would prefer to have the new functionality as part of solarium itself instead of an extension.

There're already extensions and proof of concepts I would rather re-integrate: https://github.com/solariumphp. Or we should refactor them.

Would you like to join solarium as contributor?

mkalkbrenner commented 4 years ago

I meant "committer". You're are already a "contributor" :-)

wickedOne commented 4 years ago

ok, then i'll create a new AnalyticsComponent directly into the solarium library. with the proper documentation it probably won't be too hard for people to figure out anyway.

yeah i've been looking at the solarium query builder code and from what i understand it builds a query object from a query string which is the other way around of what i'm trying to achieve. could you explain to me the usecase in which this is useful? we might want to consider a query builder which goes both directions: to and from a query string.

if you mean "member": sure! :-)

mkalkbrenner commented 4 years ago

I add you to the team :-) BTW we have a chat room at https://drupalchat.me/channel/solarium-php

wickedOne commented 4 years ago

thanks a bunch!

i'll use the chat for the somewhat more general questions as they won't be any of use for someone browsing the issue reported here...

mkalkbrenner commented 4 years ago

@wickedOne I just wanted to look into the library issue for our docker containers. But the PR is gone. Did you remove it?

mkalkbrenner commented 4 years ago

@wickedOne like I did it for search_api_solr I wanted to provide an adjusted config-set via a volume for docker.