search

solarized / xresources

Solarized for X Windows
http://ethanschoonover.com/solarized
MIT License
268 stars 62 forks source link

color8 = background color #2

Open Dosenpfand opened 11 years ago

Dosenpfand commented 11 years ago

Hello! First of, great work on the color scheme, i really like it. Only problem in the terminal, i don't think that background and color8 should both have the same value, because some programs use color8 to display text on the background and so it's invisible with the solarized color theme. So should color8 be changed? And if so to what color? The attached image shows an example, htop with missing information highlighted with red circles. 2013-02-18-175440_1366x768_scrot_E

musteresel commented 11 years ago

My personal fix is to use base01 instead of base03. According to the info, this should be the color for secondary content. Of course, color8 shares then the same color as color10. I don't know if this leads to issues with some applications.

Stoicheion commented 11 years ago

I just wanted to mention that I just tried DanielOertwig's personal fix of using base01 on color8, but it screws up Vim's background very badly in my case. Maybe my solarized config for Vim is old? Anyone else care to try his personal fix? I've been bothered by this htop issue for months now. Are there any other remedies?

musteresel commented 11 years ago

Are you using light or dark mode? I am using light mode and vim works fine. Could you take a screenshot and determine which color vim is using as the background color?

Stoicheion commented 11 years ago

Sorry for the long delay between replies. xresources On the left you can see the effect it has on Vim when I make the change. I just checked and my solarized plugin for Vim doesn't seem particularly old or nonstandard. (Last commit on that project was ages ago anyways.) Recently, I've found that putting htop in black and white mode lets everything be visible while I use this colorscheme, but of course that's not ideal. Maybe someone else who has this problem might find that useful though.

Let me know if there is any other information I can give to help us understand the issue further.

musteresel commented 11 years ago

Ugh, that is "screwed up". I took the color (hex) code from your image, which is #ff69b3 according to gimp. The closest color from solarized would be "magenta", although it's not the same.

I am just guessing here, but how about using base1 ( not base 0 1) ?

Stoicheion commented 11 years ago

Okay I found out the pink in the earlier picture is caused by me not paying attention to how to spell the color names. Apparently I missed prefixing the color name with "S_". However, S_base01 and S_base1 still result in unsatisfactory results, so sadly the problem really does exist still. Here's a new picture: xresources (At the time of this writing github's image hosting didn't seem to be working 100%. I may upload to a separate image hosting website if the issue persists long enough.) The top left window is Vim in URxvt with S_base01 for color8. The bottom left window is Vim in URxvt with S_base1 for color8. The top right window is Vim in URxvt with default solarized settings. I don't know if it will help any, but if for any reason this problem becomes particularly mysterious, I felt I should mention that any questions about very specific details in my default configuration settings can quite possibly be answered by viewing the public repository I have with my "dotfiles". Thanks for troubleshooting with me. In the end we may find that htop is an anomaly and no satisfactory solution making both htop and all other applications look nice exists (so long as we aren't patching htop). If this turns out to be the case, oh well, but I suppose it might be worth mentioning as a permanent issue in the readme or something.

TrevorBramble commented 11 years ago

Well the good news is, there's a patch. An ArchLinux AUR package has the goods. The PKGBUILD file there shows you how to compile it yourself if so inclined.

I asked the patch author about submitting it upstream in the patch's gist on GitHub.

(I've tried out that package myself--it works.)

kstep commented 10 years ago

The problem is not in htop, the problem is in solarized theme. The same problem repeats for many programs, e.g. gulp colored messages have invisible text because of the bug. Following your logic, a lot of software must be patched in order to work with solarized well. This is just total crap. If you peek yourself with a finger and feel pain everywhere, it doesn't mean all your body aches, it just means your finger is broken.

e788b1 commented 9 years ago 
URxvt.intensityStyles:   false

https://bbs.archlinux.org/viewtopic.php?id=164108

modprobe commented 9 years ago

Just for future reference if anyone is facing the problem about the vim background being gray when using the S_base(0)1 workaround: If you're also using the solarized terminal theme (and you really should be) then you can add let g:solarized_termtrans = 1 to your vimrc. Vim will then use the background of your shell.

Obviously that does not fix the original problem but it makes the workaround more workaround-able.

sam3k commented 8 years ago

For those using this theme via PuTTy, and not seeing the line numbers in Gulp eslint; you can change ANSI Black Bold to 42,161,142 and it will make it the green/bluish color. Does not seem to break other apps like VIM.