search

solarized / xresources

Solarized for X Windows
http://ethanschoonover.com/solarized
MIT License
268 stars 62 forks source link

Split light and dark color schemes #4

Closed losingkeys closed 9 years ago

losingkeys commented 11 years ago

That way someone can just use xrdb xresources/solarized-light instead of editing the file in order to switch between light and dark themes

seletskiy commented 10 years ago

Please, look at official specification (http://ethanschoonover.com/solarized#the-values), base colors should not be changed across light and dark variations. fg and bg links to this colors should be changed. It is not your mistake, it is mistake in this repo.

Take a look at my .Xresources: https://github.com/seletskiy/dotfiles/blob/master/.Xresources.dark https://github.com/seletskiy/dotfiles/blob/master/.Xresources.light

losingkeys commented 10 years ago

So this repo should be changed to more closely match your setup? I think that would make it easier to use with xrdb.

On Thu, Sep 12, 2013 at 1:11 AM, Stanislav Seletskiy < notifications@github.com> wrote:

Please, look at official specification ( http://ethanschoonover.com/solarized#the-values), base colors should not be changed across light and dark variations. fg and bg links to this colors should be changed. It is not your mistake, it is mistake in this repo.

Take a look at my .Xresources: https://github.com/seletskiy/dotfiles/blob/master/.Xresources.dark https://github.com/seletskiy/dotfiles/blob/master/.Xresources.light

— Reply to this email directly or view it on GitHubhttps://github.com/solarized/xresources/pull/4#issuecomment-24297160 .

seletskiy commented 10 years ago

@joshuarh: I'm just talking about that S_base03 and so on colors definitions should not be changed in different light modes. Looks closely at xresources file here. On line 20 we can see: #define S_base03 #002b36, but on line 32 it is defined as #define S_base03 #fdf6e3.

mpalvig commented 10 years ago

I came to the exact same conclusion after a problem with vim-colors-solarized which reversed light and dark background when light colors were set in .Xresources. The example file should be changed to reflect your method, @seletskiy, so that color0-15 are unchanged by changing terminal background.

TrevorBramble commented 10 years ago

Terribly sorry about this, everyone. Not only did I screw up the inverse color scheme (following some wording in the spec too literally) and @altercation trusted me too much to notice I'd misinterpreted it, but I've had the proper replacement and a script to generate both forms for months.

Will follow up on this as soon as I can. Thanks for your patience!

juanibiapina commented 10 years ago

It seems the version in the repo is still broken when using light colors, right?

@seletskiy version seems to be consistent.

blueyed commented 9 years ago

@TrevorBramble Ping. Can you fix this, please?

blueyed commented 9 years ago

See https://github.com/altercation/solarized/pull/68 for an attempt at using intermediate #defines.

blueyed commented 9 years ago

@seletskiy Just for info: I've used your files for a new PR: https://github.com/solarized/xresources/pull/6