solarkennedy / wine-x11-novnc-docker

Base Docker image to run wine programs in a web browser via noVNC (html5 vnc viewer) + Xvfb + x11vnc
Apache License 2.0
273 stars 103 forks source link

Don't normalize line endings #4

Closed altano closed 5 years ago

altano commented 5 years ago

git on Windows, by default, normalizes line endings on checkout by automatically converting LF to CRLF. This was causing the novnc bash and python scripts to fail on execution in bash (the shebang couldn't be parsed).

I fixed my local machine by disabling auto line ending normalization globally in git: git config --global core.autocrlf false (and everyone else should do this too)

This commit will prevent other people from hitting the issue altogether. Note that it does NOT imply all files should be treated as binary. It should only affect line ending normalization (https://stackoverflow.com/a/10017566).