search

solarmonitor / solarmonitoridl

4 stars 7 forks source link

Wrong png title on the h-alpha images #37

Open dpshelio opened 10 years ago

dpshelio commented 10 years ago

Originally reported by: Eoin Carley (Bitbucket: ecarley, GitHub: Unknown)

All images that come out of the h-alpha section of the code are labelled with the prefix 'bbso'. For example, find a kanzelhohe image on solarmonitor.org, you will notice is has the name bbso_halph_fd_YYYYMMDD_HHMMSS.png

I suggest getting rid of the prefix and just having halph_fd_YYYYMMDD_HHMMSS.png. This will probably make the php script easier e.g., php code will not have to search for a number of different file names.

dpshelio commented 10 years ago

Original comment by Eoin Carley (Bitbucket: ecarley, GitHub: Unknown):

Ok I will edit to code to label each image with the correct prefix.

dpshelio commented 10 years ago

Original comment by David PS (Bitbucket: dvdgc, GitHub: Unknown):

We can properly name them, ie. bbso_halph_fd_YYYYMMDD_HHMMSS.png and kanz_halph_fd_YYYYMMDD_HHMMSS.png and update the php accordingly. It's not that difficult and the file name would be more descriptive. If you change all to just halph_fd_YYYYMMDD_HHMMSS.png then you will have to fix that all the old files have bbso on it.

Adding kanz should be a simple change to bbso array in globals.php.