search

solarus-games / solarus

This repository was moved to GitLab: https://gitlab.com/solarus-games/solarus
http://www.solarus-games.org
Other
712 stars 133 forks source link

Bug with movements attached to lists #1106

Open Diarandor opened 6 years ago

Diarandor commented 6 years ago

This bug was explained here: https://github.com/solarus-games/children-of-solarus/issues/60 It produces slowness when tons of straight movements are being created, applied to Lua lists, and then destroyed. Note that I could be wrong about this. I copy paste the important part of my guess:

I confirm, unless I am wrong, that this seems to be an engine bug caused by built-in movements applied to Lua lists. Since my number of lists is constant and their coordinates are replaced by new ones each time they are overriden, that means that the lists or their coordinates are not the problem. So my guess is that:

either the movements are not being destroyed and they accumulate, or some "built-in coordinates" attached to the movement are becoming too big.

Diarandor commented 6 years ago

The latest version of the rain script that produces this bug is the one added in this commit: https://github.com/solarus-games/children-of-solarus/commit/8ce2c9102c48e423accd6bb265683d9708ae20ba

TeamLJS commented 6 years ago

That's maybe why I got severe slowdown with the fog script since it use a straight movement at all time