search

solarus-games / solarus

This repository was moved to GitLab: https://gitlab.com/solarus-games/solarus
http://www.solarus-games.org
Other
711 stars 133 forks source link

Add a compilation flag to force fullscreen #560

Open christopho opened 10 years ago

christopho commented 10 years ago

On some devices, we may want to force fullscreen at compilation time. In other, disable the windowed mode.

vlag commented 10 years ago

Why not let the quest decide if it allow the fullscreen for these device, and always support both at the compilation time ? It just require to add a main;get_platform() and/or main:get_os() functions, but they will also be useful for some other situations (allowing the control by mouse/touch on mobile platform for exemple)

christopho commented 10 years ago

As a quest maker, I am not skilled to guess all possible platforms and the best video choice of each. This matter is the responsability to the expert who packages the port on a specific platform.

vlag commented 10 years ago

Indeed, in this case it makes sense if both are supported by default. But for some other cases it can be useful to decide at the quest part. You won't rebuild the engine twice if you have two quest, one that deliberately forbid the fullscreen and another which allow it on the same platform, but where both mode are allowed on another platform.

Maybe the fullscreen is also not a good exemple for this actually.

christopho commented 10 years ago

Adding or not adding Lua functions to get the platform is another subject. Please open another issue to discsuss that. Thanks

ekureina commented 10 years ago

Are you talking about adding a CMake flag, or an executable command line argument? From the discussion, it seems to be the former.

christopho commented 10 years ago

Maybe we should do both.