Find and Replace dialog fixes

solarwinds / OrionSDK

SDK for the SolarWinds Orion platform, including tools, documentation, and samples in PowerShell, C#, Go, Perl, and Java.

https://thwack.com/OrionSDK

Apache License 2.0

397 stars 139 forks source link

Find and Replace dialog fixes #274

Closed pstranak-sw closed 3 years ago

pstranak-sw commented 3 years ago

A bunch of fixes for issues in the "Find and Replace" dialog. One commit per issue.

pstranak-sw commented 3 years ago

The dialog contains surprisingly lot of duplicated or unfinished code and copy-paste issues. This PR should fix the ones I encountered.

What are the plans for the whole "ScintillaNET-FindReplaceDialog" component? Do only as few changes as possible? Delete everything we don't use (IncrementalSearch, FindAllResults, GoTo)? Refactor the code we use to simplify it?

Are changes like this even OK, considering it's a 3rd-party code?

pstranak-sw commented 3 years ago

Changes are available for testing in build 3.0.0.312