search

solarwinds / OrionSDK

SDK for the SolarWinds Orion platform, including tools, documentation, and samples in PowerShell, C#, Go, Perl, and Java.
https://thwack.com/OrionSDK
Apache License 2.0
397 stars 139 forks source link

Updated SwqlStudio.csproj to use Serilog for logging #275

Open danjagnow opened 3 years ago

danjagnow commented 3 years ago

Updated SwqlStudio.csproj to eliminate the SolarWinds.Logging dependency (and a transitive dependency on log4net. It is configured instead to use Microsoft.Extensions.Logging and Serilog for logging. The log file path is no longer configurable via the App.config file in this approach. Updated the installer to add the new dependencies, including transitive dependencies. The SolarWinds.Logging and log4net assemblies are still deployed since SolarWinds.InformationService.Contract still depends on them. This is not ready for merging.

danjagnow commented 3 years ago

This PR is just a request for comment. Switching up the logging like this makes it easier to swap out logging approaches in the future, and it would allow us to remove the SolarWinds.Logging abstraction, but it also means a larger MSI installer because of the many transitive dependencies involved. If this approach makes sense, we'd want to remove SolarWinds.Logging and log4net uses throughout the solution before merging anything. If not, we should just close this PR.

tdanner commented 3 years ago

This seems reasonable to me. The extra DLLs are a mild nuisance, but not a big deal.

danjagnow commented 3 years ago

This seems reasonable to me. The extra DLLs are a mild nuisance, but not a big deal.

OK, let me do a little work and turn this into a real PR, then.