AO-21098-Add-Support-for-Node-18-Replacing-17

[ronilan]

Overview

This pull request adds support or Node 18 replacing Node 17.

Changes

Changes are limited to dev setup and GitHub Actions workflows.

Issues

• The restify probe tests fail with node 18. The probelm is with restify itself, not with the probe. See: https://github.com/restify/node-restify/issues/1888. Tests disabled for Node 18.
• Results of Document workflow showed support for restify versions 4.1.0-6.2.0 with Node 10, 12, 14, 16, and 17. However, the workflow itself has a known issue with restify (see: AO-20494). Versions 7.x and 8.x are supported by Node 16 and were supported by 17. The error with Node 18 is a new issue with the package.

Tests

All acceptance tests pass. Document workflow ran as expected. Supported components data generated.

[ronilan]

LGTM, thanks @ronilan! Curious, is the additional check in test/versions.js required in addition to the semver check in test/probes/restify.tests.js or an optimization?

test/probes/restify.tests.js -> tests -> all day-to-day workflows test/versions.js -> testeachversion -> Document workflows -> supported components

Version check in test file makes sure test do not fail, as a result testeachversion assumes the version is good, thus must exclude version explicitly from the versions checked.

Yep. Complex...