Closed ronilan closed 2 years ago
This pull request fixes the http probe tests so that they actually run as expected.
Since the tests did not run as expected, an issue with bindings/liboboe trace continuation when Downstream was not detected.
With the fixed tests, a test will fail when using bindings below version 12.0.0-nh.2 (comes with liboboe 10.5.0).
12.0.0-nh.2
10.5.0
See: https://github.com/appoptics/appoptics-apm-node/runs/6713249942?check_suite_focus=true
57 suites in 5 groups passed 2 suites in 1 group failed PROBES: test/probes/http.test.js test/probes/https.test.js
All tests will pass once https://github.com/appoptics/appoptics-bindings-node/pull/118 is merged and the updated bindings are installed in the agent nh-main branch from the bindings nh-main branch. see: https://github.com/appoptics/appoptics-apm-node/actions/runs/2429881575
nh-main
Overview
This pull request fixes the http probe tests so that they actually run as expected.
Status
Since the tests did not run as expected, an issue with bindings/liboboe trace continuation when Downstream was not detected.
Change
With the fixed tests, a test will fail when using bindings below version
12.0.0-nh.2
(comes with liboboe10.5.0
).See: https://github.com/appoptics/appoptics-apm-node/runs/6713249942?check_suite_focus=true
All tests will pass once https://github.com/appoptics/appoptics-bindings-node/pull/118 is merged and the updated bindings are installed in the agent
nh-main
branch from the bindingsnh-main
branch. see: https://github.com/appoptics/appoptics-apm-node/actions/runs/2429881575Notes