NH-14027-Fix-q-Probe - Githubissues

solarwinds / appoptics-apm-node

AppOptics APM Instrumentation Agent for Node.js

Apache License 2.0

11 stars 9 forks source link

NH-14027-Fix-q-Probe #277

Closed ronilan closed 2 years ago

ronilan commented 2 years ago

Overview

This pull request fixes issues with the q probe so that it only binds when tracing (i.e. in the context of an http request).

Status

The probe generated excessive logging when used outside the context of an http request. It that was apparent in test runs and caused customer concern.
A fix similar to the one in the pull request was implemented in the bluebird probe a while back.

Change

Probe was changed to only bind functions when tracing. Tests were cleaned.

Notes

Pull Request merges into nh-main. Agent built from master will stay "unfixed"`.