solarwinds / nova

Apache License 2.0
23 stars 19 forks source link

Able to resize a panel beyond collapse button #207

Open ross-moug opened 3 years ago

ross-moug commented 3 years ago

Describe the bug When using a Panel component which is resizable then the user can shrink the side pane to beyond the side pane header's width (including the collapse button).

Setting panelMinSize would solve this but we are using this in a generic way so we'd like to be able to set the min-width of the Panel (or the panelMinSize) dynamically based on the header content.

To Reproduce Steps to reproduce the behaviour:

  1. Go to the Nova docs
  2. Scroll to the "Enabling Resizability" example
  3. Manually change the header text via Dev tools to a string which is longer than 150px
  4. Click and drag the side pane

Expected behaviour The side pane prevents the user resizing it below the minimum width of the side header (including the collapse button).

Screenshots Clicking and dragging pane boundary image-2021-03-31-14-46-22-163

Click and drag released image-2021-03-31-14-46-54-247

Dev tools showing resizer min-width MicrosoftTeams-image (5)

Environment (please complete the following information):

Additional context We have currently hit this issue on Nova 9 so a workaround, if available, would be appreciated until we can upgrade to Nova 11 (and Angular 11).

ross-moug commented 3 years ago

If you can access N-able repos, here is a proposed solution to workaround this issue on Nova 9: https://github.com/logicnow/msp-entity-module/compare/bugfix/RMM-40300_preventSidePaneShrinkingBelowHeaderMinWidth.

ewok-janitor commented 3 years ago

https://jira.solarwinds.com/browse/NUI-5966