solarwinds / nova

Apache License 2.0
23 stars 19 forks source link

Add RiskScore Component to the Bits package #639 #648

Closed MykhailoMolyboha closed 12 months ago

MykhailoMolyboha commented 1 year ago

Related Jira item

https://swicloud.atlassian.net/browse/OO-23867

Issue

https://github.com/solarwinds/nova/issues/639

Description

Add Fusion shared 'Risk Score' component

Screenshots (if applicable)

mockup image

/components/RiskScoreComponent.html#example image

Definition of done

Blakesalot commented 1 year ago

Hi, @MykhailoMolyboha đź‘‹ I'm no longer a Nova maintainer so I have no official say in this, but in my opinion this component is very feature-specific and should live somewhere else besides the Nova libraries. The set of components in Nova has been carefully curated to ensure that they all meet a minimum amount of general usefulness before being included. In this case, I would recommend adding it to the specific project that needs it and reuse it from there, but I'll defer to the existing package owners on the final decision.

Blakesalot commented 1 year ago

@MykhailoMolyboha, I should point out that Nova Charts does have a gauge component with radial (donut) and linear modes that was intended for use cases similar to this.

Here are the docs for that: https://nova-ui.solarwinds.io/charts/main/additional-documentation/chart-types/gauge.html And, here is the source code: https://github.com/solarwinds/nova/tree/main/packages/charts/src/gauge

The look and feel are tailored to the Nova design spec, so it doesn’t look the same as the component in this PR, but it offers capabilities similar to those needed by your use case. And, it could potentially be enhanced to fulfill any requirements that it currently doesn’t meet.

findo11 commented 1 year ago

Approved, but please consider Blake's idea.