search

solbu / hldig

hl://Dig is a fork of ht://Dig, a web indexing and searching system for a small domain or intranet
https://solbu.github.io/hldig/
Other
18 stars 21 forks source link

Fuzzy.cc:strings need to be marked for translation #118

Open andy5995 opened 6 years ago

andy5995 commented 6 years ago

There are strings in this file that need to be marked for translation.

https://github.com/solbu/hldig/blob/f276b92ca3f0b59a165b878a517b38d9cd71b26f/hlfuzzy/Fuzzy.cc#L170

shrey183 commented 6 years ago

Hi, I would love to work on this issue, but I am not sure I understand your requirement. Could you give an example?

solbu commented 6 years ago

If you look on line 169 you find a string that is not makred for translation, but on line 175 and 176, some 6 lines below that, you'll see an example of strings that are marked for translation.

For example, in the line 169 you find this code: cout << "hlfuzzy: words: " << count << '\n'; The quoted string need to be enclosed in _().

Here is an example. I'll have the original just below so you see the difference easily: cout << _("hlfuzzy: words: ") << count << '\n'; << Fixed cout << "hlfuzzy: words: " << count << '\n'; << Original

shrey183 commented 6 years ago

Hi, thanks for your comment, I created a Pull Request and I see this after making the pull request: image

Have I done something wrong? I am kind of new to this, so any comments from you all would be really helpful.

solbu commented 6 years ago

This is exactly how it's done. :-)