search

solbu / hldig

hl://Dig is a fork of ht://Dig, a web indexing and searching system for a small domain or intranet
https://solbu.github.io/hldig/
Other
18 stars 21 forks source link

start_highlight and end_highlight attributes incorrectly named start_hightight and end_hightight in hlcommon/defaults.cc #147

Open iandiver opened 1 year ago

iandiver commented 1 year ago

I found that matched words in search result excerpts were not highlighted by default even though the documented default values for the attributes start_highlight and end_highlight are "< strong >" and "< /strong >" respectively. I remembered from an earlier ht://Dig installation that these highlights were present by default. I checked the source and found these default values in hlcommon/defaults.cc but they are associated with the attribute names start_hightight and end_hightight, which are incorrect. I propose renaming these back to start_highlight and end_highlight. I notice some other default behaviors were not enabled as documented so it is possible there are other misnamed attributes in default.cc. I will try to check them. Let me know if someone else is working on this.

solbu commented 1 year ago

Unfortunately, no one has been working on anything for quite a while. The original developer who forked the project gave it to me for some reason that is unclear to me, but I was happy to take it, in order to at least /try/ to keep it alive. :-)

I am an RPM packager. I used to create RPM packages for Mandriva, and since 2012 for Mageia. My specialty is installation using the GNU Autotools (the configure and Makefile scripts).

But I don't know programming.

So if you see something that needs fixing, please go ahead. :-)

iandiver commented 1 year ago

OK, thanks. I just checked the full list of attributes and I didn't find any other unexpected mismatches. I'll submit a pull request for an updated version of defaults.cc.