solbu / hldig

hl://Dig is a fork of ht://Dig, a web indexing and searching system for a small domain or intranet
https://solbu.github.io/hldig/
Other
18 stars 21 forks source link

not all required files are included in 'make dist' archive #99

Closed andy5995 closed 6 years ago

andy5995 commented 6 years ago

make dist doesn't package all required files.

I noticed gettext.h isn't included, and some files from htdb/

solbu commented 6 years ago

I notice that the files not included in htdb/ is not compiled. I suspect that is because they are not included in Makefile.am.

According to «git log htdb/Makefile.am» or «gitk htdb/Makefile.am» they where never included, and hence never built at any point in the projects history. «gitk htdb/» also show that the only changes to the files as far back as february 2000, the only changes to the not included files are changes to copyright years.

The question then becomes, are they needed?

andy5995 commented 6 years ago

Can this be closed?

solbu commented 6 years ago

I think it can. If something emerge that isn't fixed, we can allways reopen it.