Utilize node/npm for the dist build step.

sole / Animated_GIF

Javascript library for creating animated GIFs

https://sole.github.io/Animated_GIF

225 stars 53 forks source link

Utilize node/npm for the dist build step. #9

Closed tec27 closed 10 years ago

tec27 commented 10 years ago

This removes a dependency on a unix-like environment for building the dist files, and makes it easier to pull in the necessary build dependencies (browserify, uglify).

sole commented 10 years ago

Thank you for the PR but... can't it be shorter? I'm mystified by how long it is.

Seriously, the bash script is sweet and short and I get the point of what's happening by just having a quick look. Can't the same thing be done with node? :-S

tec27 commented 10 years ago

Reworked how the building was done, should be a bit more straightforward/shorter now.

Another alternative would be splitting the currently existing shell script into a set of package.json scripts, which would be shorter but a bit less flexible. I don't have much preference between either of these approaches, happy to move this PR in whichever direction you feel is best!

sole commented 10 years ago

This is awesome. Also I pressed BACK when I wasn't focused on this comment form and when I tried to go forward github deleted all the great comment I wrote, so :sadface:, but many thanks!