solean / ibooks-highlights

Extract iBooks highlights
https://www.npmjs.com/package/ibooks-highlights
MIT License
9 stars 0 forks source link

Add support for deleted annotations #2

Closed damien-king closed 3 years ago

damien-king commented 3 years ago

Hi!

Thanks for making this, it's super helpful :). I would create a PR but no permissions.

Hoping to add:

zannotationdeleted to const ANNOTATIONS_QUERY in constants.js

and something to the effect of

    var annotation = {
      ...,
      deleted: rawAnnData.ZANNOTATIONDELETED === 1 ? true: false
    };

So I can filter out deleted annotations when I'm querying.

Thanks!

solean commented 3 years ago

Hey. I think you should be able to submit a PR if you fork the repo and create a new branch. If not, I can make the change but you should get the commit credit since it was your idea lol.

solean commented 3 years ago

Added in commit: d63131