Integrate requirement for autopep8 into the travis scripts

solent-eng / solent

Free software sequencer architecture

GNU Lesser General Public License v3.0

7 stars 4 forks source link

Integrate requirement for autopep8 into the travis scripts #29

Open cratuki opened 7 years ago

cratuki commented 7 years ago

We're consolidating on autopep8.

Work:

Configure Travis script to check for a zero diff between the code as it is and autopep8 code.
Creating some quick docs to show users how to create their own git precommit file.

petr-tik commented 7 years ago

good video on why auto-formatting matters

petr-tik commented 7 years ago

alternative to pep8 https://github.com/google/yapf

cratuki commented 7 years ago

I can't see any problems with autopep, and it seems to have momentum. It needs to be done, but for myself, I'm currently more excited about using demos to prove this stuff in anger than do more source-tidy.

cratuki commented 7 years ago

@petr-tik, I should have done this a while ago. This needs to happen, but I'm distracted by a bunch of other things. If you know what the next step is and it's trivial for you, would you please execute on it? I'll merge as soon as you do.

cratuki commented 7 years ago

@petr-tik Actually, better yet is if you could just point me to the three steps that need to happen. Then I'll make hte change. Weird I should be asking, I'm sure it's straightforward. My brain is currently invested in other things.

petr-tik commented 7 years ago

last time we spoke you wanted to work out which code style you have and make current codebase consistent, before adding to ci. To-do:

[ ] agree on desired autopep8 settings
[ ] make current codebase adhere to new standard
[ ] add standard to CI

cratuki commented 6 years ago

Depends on #67