solero / houdini

A Club Penguin private server written in Python 3
https://houdini.readthedocs.io/
MIT License
281 stars 54 forks source link

Improve stamps end screen #101

Closed nhaar closed 2 weeks ago

nhaar commented 1 month ago

This PR aims in general to fix the stamps end screen and add the Card-Jitsu ones

Stamps end screen fix

This is how the end screen would always look like:

1

However, if you didnt earn any new stamps, it should display like this

2

which is fixed now. In AS3, the stamps from the current session show highlighted, and the stamps from previous session don't, which was not correct before and is now fixed:

3

Card-Jitsu stamps end screen

At the end of the card-jitsu games, if a player gained a stamp, a special card-jitsu end screen shows up. Here are some screenshots from AS2 and AS3 of how they look like in this PR:

4 5 6 7

Card-Jitsu Water and Fire fixes

Two minor fixes because they got in the way of testing this PR:

  1. Card-Jitsu water properly handles when a player exits now
  2. Card-JItsu fire stamps for the Coat and Suit were wrong
nhaar commented 1 month ago

I have changed it to use redis so it no longer needs database migrating

AllinolCP commented 1 month ago

Instead of using redis or new db column what about using the recent column included with stamps? Ref: https://github.com/solero/houdini/blob/f6f9f39c22122c91246fb0a9043f36ed829348b7/houdini/data/stamp.py#L56

nhaar commented 1 month ago

It could be used, but as far as I know that is not how it worked in the original