search

solero / houdini

A Club Penguin private server written in Python 3
https://houdini.readthedocs.io/
MIT License
281 stars 54 forks source link

Update fire.py #63

Closed AllinolCP closed 3 years ago

AllinolCP commented 4 years ago

fix the card being undefined/ cart surfer

ben-pearce commented 4 years ago

I understand the solution to this bug involves removing some playable cards from the game..

Is there some pattern that could yield us this list from the card attributes instead of listing them out by hand? You have quite a large array that is iterated each time card is dealt.

https://github.com/solero/houdini/pull/63/commits/8f2b36c734c89fb65b616e9f1f312a8c4a96f60c

Do these cards have something in common that the buggy cards do not, attribute-wise. Would it be more efficient to exclude cards from play rather than include all cards that are playable?