search

solesensei / notion-game-list

Notion game list
https://solesensei.github.io/notion-game-list/
MIT License
40 stars 1 forks source link

Continue even if data is not found #7

Closed Yoddikko closed 2 years ago

Yoddikko commented 2 years ago

If the app can't retrive info from the Steam store it will just continue fetching the other games instead of aborting the whole operation.

solesensei commented 2 years ago

Hi @Yoddikko, it's definitely the issue.

Your PR won't fix the problem, it will skip the branch of code that fetches data from steam library

I think the issue #6 is about that broken part of code you skip here. Something was changed in an API. I will check it later.

You can try to use --skip-non-steam argument to get the same behaviour you added here.

Yoddikko commented 2 years ago

Thank you for your answer. Also I have another last issue with your amazing project: it would be cool to have a hours only time played stamp. Because if on Notion I want to sort for most played or less played the games I played only some minutes get mixed with the game I played hours. It happens because maybe on a game I have 100 minutes and on another game I have 2 hours. It should be on top the one with 2 hours, but instead it goes under the one with 100 minutes. I was trying to apply a fix that if you want I can show you my code but I never coded in Python and I got some errors. My solution by the way was transforming minutes in hours, so that for example 30 minutes would be 0.5 hours, so that the sorting would be working correctly and the output wuold be only never or in hours.

solesensei commented 2 years ago

@Yoddikko feel free to create an issue :)

solesensei commented 2 years ago

Fixed in https://github.com/solesensei/notion-game-list/pull/10