solettaproject / soletta-dev-app

Soletta Development Application
Apache License 2.0
7 stars 13 forks source link

fix: Allow to files to have space in names #134

Closed brunobottazzini closed 8 years ago

brunobottazzini commented 8 years ago

Soletta Dev App was not allowing to create/remove/save project or files with space in its name. For instance a project called "the project".

This patch also fix some empty chars in the of lines.

Signed-off-by: Bruno Bottazzini bruno.bottazzini@intel.com

brunobottazzini commented 8 years ago

@kamidipreetham, could you review this patch please :)

thanks!!

preetham commented 8 years ago

@brunobottazzini The patch works fine w.r.t allowing spaces in project/file/folder names. But major problem is now it allows project/file/folder names to start with '.' (dot) which potentially erased 'demo' folder in my tests. We can put-up a regex based check before executing the create procedure.

brunobottazzini commented 8 years ago

@kamidipreetham good test case man!!!

I haven't thought on creating a file with . in front of it.

I will merge this patch and fix this issue in another PR

thanks