search

solettaproject / soletta-dev-app

Soletta Development Application
Apache License 2.0
7 stars 13 forks source link

highlight syntax: uppercase var name is blue #66

Closed brunobottazzini closed 8 years ago

brunobottazzini commented 8 years ago

The R from RotaryAngleSensor shouldn't be blue, only the nodetypes and the ports

screenshot from 2016-03-17 14 26 23

barbieri commented 8 years ago

actually, RotaryangleSensor is a type name, so it all should be in blue :-)

Same for LCDString, not just LCD, but the whole LCDString

to me looks like an incorrect regexp, likely it should be:

[(]([^:)]+)[:)]

That is: after the parenthesis [(] you create a group of more than one character that are not )or :, that is ([^:)]+), then ends with ) or : as terminators

brunobottazzini commented 8 years ago

Yes! Makes sense.

I will test this regexp thanks

brunobottazzini commented 8 years ago

Fix proposed: https://github.com/solettaproject/soletta-dev-app/pull/68

Thanks the regexp worked really well :+1:

brunobottazzini commented 8 years ago

Fixed with patch -> https://github.com/solettaproject/soletta-dev-app/pull/69/