search

solettaproject / soletta-dev-app

Soletta Development Application
Apache License 2.0
7 stars 13 forks source link

Only first group of node types is displayed in Cheat Sheet when using firefox #76

Closed otaviobp closed 8 years ago

otaviobp commented 8 years ago

When using firefox browser, the Cheat Sheet only display first group of node types. In chrome web browser it works fine. Tested with soletta-dev-app beta17

screenshot_20160411_175737

bdilly commented 8 years ago

I'm using Firefox 45.0 and it seems to be working fine

bdilly commented 8 years ago

I'm checking it against our online version (not beta17) - http://solettaproject.github.io/docs/nodetypes/

otaviobp commented 8 years ago

The online version is working fine here too (using firefox 45.0.1). Tested with dev-app on master and it is also failing.

brunobottazzini commented 8 years ago

Yes I can confirm this bug.

When looking in the console errors the firefox points to me for this: https://github.com/desandro/get-size/#firefox-hidden-iframe-bug

It is a conflict between angularjs and firefox. The angular uses the "display: none".

I will go through this bug

brunobottazzini commented 8 years ago

@bdilly, @otaviobp proposed fix here: https://github.com/solettaproject/soletta-dev-app/pull/100

Can you guys test/review it ?

otaviobp commented 8 years ago

lgtm. Tested and working fine.

otaviobp commented 8 years ago

ops, commented in wrong place

brunobottazzini commented 8 years ago

Patch merged and issue resolved. Thanks!