solex2006 / SELIProject

SELI Project
9 stars 17 forks source link

Course - Video gallery and Videos #159

Open flaviolima opened 4 years ago

flaviolima commented 4 years ago

:warning: Wire-frames and live-demos are just for example purpose. They don't meet entirely this requirement.

:pencil2: Pencil icon marks specs that are waiting for definition


Live-Desmo using VideoJS that provides full compatibility with track (vtt files), including screen reader recognize of speak audio description track. Select Elephants Dream video to test accessibility


Table Of Content

  1. Video alternatives
    1. Video-Only alternatives
  2. Video provided by teachers
    1. General considerations
    2. Rendering single video
    3. Video Gallery

Video alternatives

In order to images be accessible it's necessary to be provided:

Video-Only alternatives

In order to images be accessible it's necessary to be provided:

Video provided by teachers

Videos from course creation should follow Video alternatives specification (above) additional to bellow requirements

General Considerations

    • [x] Separating information and structure from presentation to enable different presentations (meet #76)
    • [ ] meet #135
    • [ ] meet #97
    • [ ] contrast ratio for boundaries ≥ 3:1 (meets #98 )
    • [x] font color with at least minimum contrast (#92)
    • [ ] Text can be resized to 200% ( meets #93)
  1. Text Spacing (meet #99)
      • [x] Line height (line spacing) to at least 1.5 times the font size;
      • [x] Spacing following paragraphs to at least 2 times the font size;
      • [x] Letter spacing (tracking) to at least 0.12 times the font size;
      • [x] Word spacing to at least 0.16 times the font size.
  2. on focus and hoover
      • [ ] provide a visible indicator (meet #116 minimum)
          • [ ] meet #90 (multiple visual cues) Suggestion: combine colors (e.g. font-color, border-color) and shapes (e.g font-weight , border-line)
          • [x] meet enhanced scenario of #116 by setting focus indicator minimum area, contrast and thickness

Rendering single video

Fields from Authoring Tool

    • [ ] aria-label="shortDescription or aria-label="title" (if short description is not provided)
    • [ ] aria-describedby=Transcription`
    • [ ] warning about seizure risk, if HasRisk==true
    • video player could load inactive, and user must confirm that he is aware of the risk, clicking in a checkbox

Pure HTML5 example *live-demo uses videojs instead

<figure id="id_video_box">
   <h3>VIDEO TITLE</h3>
   <p id="id_short_desc"><!-- SHORT DESCRIPTION --></p>
   <video id=video poster="poster.png" autoplay="false" aria-label="id_short_desc" aria-describedby="id_long_desc">
       <source id='mp4' src="trailer.mp4" type='video/mp4'/>
       <!-- Track to be used for CAPTIONS -->
       <track kind="captions" label="English[cc]" src="captions_en.vtt" srclang="en" default></track>
       <!-- Track to be used for AUDIO-DESCRIPTION as .vtt -->
       <track kind="descriptions" label="English[desc]" src="audiodesc_de.vtt" srclang="en"></track>
       <p>Your user agent does not support the HTML5 Video element.</p>
   </video>
</figure>
<figcaption id="id_long_desc"><!-- TRANSCRIPTIONS --</figcaption>

Video Gallery

Video widget is composed by

    • [ ] #136 Design Pattern: must follows WAI-ARIA Practices for grid
        • [x] aria-label and visibel label "Image gallery" ( meet #136 #16 )
        • [x] role=grid
  1. 101 keyboard navigation

      • [x] tab and Shift + tab: Navigate to/away gallery
      • [x] left and right arrow: Navigate through gallery's images
      • [x] Enter and Space: Open fullwidth preview
    • [x] Responsive design
      1. large viewport presents 8 thumbnails in one row
      2. medium viewport presents 3-7 thumbnails by row
      3. small viewport presents 2 thumbnails by row
      4. smallest viewport 1 thumbnail by row
    • [ ] warning about seizure risk, if HasRisk==true . When user select to open fullwidth preview, open an alertdialog
      1. To open the full width preview, User must check the checkbox confirming that he is aware of the risk and then click in CONTINUE button.
      2. To not open the full width preview, user must use CANCEL button

Thumbnails

    • [x] Focus indication
    • [ ] Hover indication
    • [x] Each thumbnail is a <figure> tag
        • [ ] alt attribute of will be the "short description" configured by teacher
        • [ ] alt attribute of will be the "title" if no short description was set by teacher.
        • [x] figcaption will be the "title".
          <figure role="group">
          <img src={poster} alt={shortDescription} />
          <figcaption>{title}</figcaption>
          </figure>

Full width Preview

    • [ ] Fullwidth dialog (layout design consistency #51)
    • [ ] Design Pattern: must follows WAI-ARIA Practices for modal (meet #136)
        • [ ] role="dialog"
        • [ ] keyboard navigation (meet #101 )
        • [ ] aria-modal=true
        • [x] aria-describedby=
        • [ ] First focus
        • [ ] Focus after dialog is closed
  1. Button Controls
      • [ ] provide a label that identifies the purpose of the buttons (meet #16 #76 #136)
      • [ ] #119 Accessible name should be the function the button serves

Wire-Frames

image

image

State indicators (focus and hoover)

image

Fullwidth preview

small screen image

medium screen image

large screen image

github-actions[bot] commented 4 years ago

This Feature is ready to be implemented.

ecureuill commented 4 years ago

Not complying with specification

Please, move to CODED only when this feature is fully implemented: bugs reported in comments and requirements in OP If you want that we test some partial solution, add a comment here with our @

github-actions[bot] commented 3 years ago

This feature have been implemented and is ready for Funcional Test. Please, test the feature.

rebeccamello commented 3 years ago



image


image

juantenesaca commented 3 years ago

Hello @rebeccamello,

Youtube videos are not accessible, but we still give the opportunity to the tutor to create content with it, I think maybe, we have to block the options of accessibility when a tutor decides to insert this type of content in the courses (There is no requirement for this for now). Please use another sources for this test. When you are adding the video link the systems tells you in green, but if not the message is in yellow.

caroltaus commented 3 years ago


Steps to reproduce:

1- create a video content 2- go to the upload from url tab 3- go to upload from library tab 4- upload a video from library 5- save the content 6- the "This content has no accessibilty. Do you want to proceed?" modal is shown

EduKobaiashi commented 3 years ago


image

juantenesaca commented 3 years ago

Hello @EduKobaiashi,

For the moment it does not exist any HasRisk field to select in the tutor side, or any attribute created to store this boolean in the database. No wireframe or anything, for example, when it has to be selected or the place that it should go. So we are not going to do any more for this.

Warning for seizure of a single video does not not work in tutor side, because the preview is showed in a dialog. But in the student side works very well. You can review it again.

EduKobaiashi commented 3 years ago

Hello @juantenesaca , I think the HasRisk field that is specified is this one in the screenshot, when the tutor selects if the content could provoke photosensitive seizures.

image

Fields from authoring tool (As in this issue specification): image

About the single video, I just tested as a student and the checkbox only appears when the user goes to fullscreen, but the video can still be played without being in fullscreen. According to Camilla's specification, the user shouldn't be able to play the video until the checkbox is checked.

juantenesaca commented 3 years ago

@EduKobaiashi ok, thank you very much for this value information. I was miss understanding that part. I will be committing this changes.