Open flaviolima opened 4 years ago
This Feature is ready to be implemented.
It's not complying with specs
Functional Test failed! Please, review your solution.
Please, move to CODED only when this feature is fully implemented: bugs reported in comments and requirements in OP If you want that we test some partial solution, add a comment here with our @
This feature have been implemented and is ready for Funcional Test. Please, test the feature.
[ ] There are still tasks in the requirement to be done
[x] Page is inaccessible for screen reader + keyboard nav (for example, image gallery instructions are not being read)
[x] Color contrast is not accessible
[x] gallery instructions are still not being with screen reader + keyboard nav
[x] when hoovering there should a visible indicator
Hello @caroltaus ,
Image gallery instructions id is for example "gallery-instructions". So in main gallery we use aria-describedby="gallery-instructions". So it means that gallery instructions are read when you focus the gallery no the instruction section itself. Please review again that part, I also showed that on a meeting. About "when hoovering there should a visible indicator", please provide more information.
Instructions are okay, thank you!
The focus indicator is explained in issue https://github.com/solex2006/SELIProject/issues/116 The gallery is not doing this:
OK, thank you so much. It was already working I do not know what happened. I am fixing it right now.
@juantenesaca okay thank you :)
:warning: Wire-frames and live-demos are just for example purpose. They don't meet entirely this requirement.
:pencil2: Pencil icon marks specs that are waiting for definition
Table Of Content
Image's Text Alternative
In order to images be accessible it's necessary to be provided:
Check this tutorial
[x] short description in
alt=
attribute[ ] long description as
<figcaption>
or aslongdesc="URL"
[ ] Decorative images do not need text alternative and should receive an empty
alt=""
attribute.[ ] In case of missing short description in a non-decorative image, do not insert an empty
alt=""
attribute, instead remove thealt
attribute[x] :warning: Browser and Screen Readers compatibility We are following WCAG and HTLM5 specs, but adjustments to compatibility should be necessary.
Images provided by teachers
Images from course creation should follow Image's Text Alternative specification (above) additional to bellow requirements
General Considerations
Rendering single image
<figcaption>
should be inserted after or before<img>
given longDescriptionPosition valuealt="shortDescription
oralt="title"
(if short description is not provided)Image should be rendered accordingly to it purpose:
imagePurpose=Informative
<img src="INFORATIVE_purpose.png" alt=[shortDescription]>
imagePurpose=ImageOfText
<img src="TEXT_purpose.png" alt=[shortDescription]>
imagePurpose=Decorative
<img src="DECORATIVE_purpose.png" alt="">
imagePurpose=ComplexImage
Image Gallery
Gallery widget is composed by
aria-label
and visibel label "Image gallery" ( meet #136 #16 )role=grid
101 keyboard navigation
Thumbnails
<figure>
tagalt
attribute of will be the "short description" configured by teacheralt
attribute of will be the "title" if no short description was set by teacher.figcaption
will be the "title".Full width Preview
role="dialog"
aria-modal=true
aria-describedby=
Wire-Frames
State indicators (focus and hoover)
Fullwidth preview