solex2006 / SELIProject

SELI Project
9 stars 17 forks source link

Course - Image Gallery and Images #160

Open flaviolima opened 4 years ago

flaviolima commented 4 years ago

:warning: Wire-frames and live-demos are just for example purpose. They don't meet entirely this requirement.

:pencil2: Pencil icon marks specs that are waiting for definition



Table Of Content

  1. Image's Text Alternative
  2. Images provided by teachers
    1. General considerations
    2. Rendering single image
    3. Image Gallery

Image's Text Alternative

In order to images be accessible it's necessary to be provided:

Check this tutorial

Images provided by teachers

Images from course creation should follow Image's Text Alternative specification (above) additional to bellow requirements

General Considerations

    • [ ] Separating information and structure from presentation to enable different presentations (meet #76)
    • [ ] meet #135
    • [x] meet #97
    • [ ] contrast ratio for boundaries ≥ 3:1 (meets #98 )
    • [x] font color with at least minimum contrast (#92)
    • [ ] Text can be resized to 200% ( meets #93)
  1. Text Spacing (meet #99)
      • [x] Line height (line spacing) to at least 1.5 times the font size;
      • [x] Spacing following paragraphs to at least 2 times the font size;
      • [x] Letter spacing (tracking) to at least 0.12 times the font size;
      • [x] Word spacing to at least 0.16 times the font size.
  2. on focus and hoover
      • [ ] provide a visible indicator (meet #116 minimum)
          • [ ] meet #90 (multiple visual cues) Suggestion: combine colors (e.g. font-color, border-color) and shapes (e.g font-weight , border-line)
          • [ ] meet enhanced scenario of #116 by setting focus indicator minimum area, contrast and thickness

Rendering single image

    • [ ] <figcaption> should be inserted after or before <img> given longDescriptionPosition value
    • [x] alt="shortDescription or alt="title" (if short description is not provided)
  1. Image should be rendered accordingly to it purpose:

      • [ ] if imagePurpose=Informative <img src="INFORATIVE_purpose.png" alt=[shortDescription]>
      • [ ] if imagePurpose=ImageOfText <img src="TEXT_purpose.png" alt=[shortDescription]>
      • [ ] if imagePurpose=Decorative <img src="DECORATIVE_purpose.png" alt="">
      • [ ] if imagePurpose=ComplexImage
        <figure role="group">
        <img src="COMPLEX_purpose.png" alt=[shortDescription]>
        <figcaption>[longDescription]</figcaption>
        </figure>

        Image Gallery

        Gallery widget is composed by

      • image's thumbnails
      • fullwidth preview
    • [ ] #136 Design Pattern: must follows WAI-ARIA Practices for grid
        • [x] aria-label and visibel label "Image gallery" ( meet #136 #16 )
        • [x] role=grid
  2. 101 keyboard navigation

      • [x] tab and Shift + tab: Navigate to/away gallery
      • [x] left and right arrow: Navigate through gallery's images
      • [x] Enter and Space: Open fullwidth preview
    • [x] Responsive design
      1. large viewport presents 8 thumbnails in one row
      2. medium viewport presents 3-7 thumbnails by row
      3. small viewport presents 2 thumbnails by row
      4. smallest viewport 1 thumbnail by row

Thumbnails

    • [x] Focus indication
    • [x] Hover indication
    • [x] Each thumbnail is a <figure> tag
        • [x] alt attribute of will be the "short description" configured by teacher
        • [x] alt attribute of will be the "title" if no short description was set by teacher.
        • [x] figcaption will be the "title".
          <figure role="group">
          <img src= alt={shortDescription} />
          <figcaption>{title}</figcaption>
          </figure>

Full width Preview

    • [x] Fullwidth dialog (layout design consistency #51)
    • [ ] Design Pattern: must follows WAI-ARIA Practices for modal (meet #136)
        • [x] role="dialog"
        • [x] keyboard navigation (meet #101 )
        • [x] aria-modal=true
        • [ ] aria-describedby=
        • [x] First focus
        • [x] Focus after dialog is closed
  1. Button Controls
      • [ ] provide a label that identifies the purpose of the buttons (meet #16 #76 #136)
      • [x] #119 Accessible name should be the function the button serves

Wire-Frames

image

image

State indicators (focus and hoover)

image

Fullwidth preview

image

github-actions[bot] commented 4 years ago

This Feature is ready to be implemented.

ecureuill commented 4 years ago

It's not complying with specs

ecureuill commented 4 years ago
github-actions[bot] commented 4 years ago

Functional Test failed! Please, review your solution.


Please, move to CODED only when this feature is fully implemented: bugs reported in comments and requirements in OP If you want that we test some partial solution, add a comment here with our @


github-actions[bot] commented 4 years ago

This feature have been implemented and is ready for Funcional Test. Please, test the feature.

caroltaus commented 4 years ago
caroltaus commented 3 years ago
juantenesaca commented 3 years ago

Hello @caroltaus ,

Image gallery instructions id is for example "gallery-instructions". So in main gallery we use aria-describedby="gallery-instructions". So it means that gallery instructions are read when you focus the gallery no the instruction section itself. Please review again that part, I also showed that on a meeting. About "when hoovering there should a visible indicator", please provide more information.

caroltaus commented 3 years ago

Instructions are okay, thank you!

The focus indicator is explained in issue https://github.com/solex2006/SELIProject/issues/116 The gallery is not doing this:

image

juantenesaca commented 3 years ago

OK, thank you so much. It was already working I do not know what happened. I am fixing it right now.

caroltaus commented 3 years ago

@juantenesaca okay thank you :)