ecureuill commented 4 years ago

:warning: Wire-frames and live-demos are just for example purpose. They doesn't meet entirely this requirement.

:pencil2: Pencil icon marks specs that are waiting for definition

Platform search

demo current page

[x] The platform search should perform a search in all contents within the platform
- Subscribed Courses (only for authenticated students)
- Courses
- Support: FAQ, Help, Documentation
- News, Blog
[x] The results should be presented grouped by
- Subscribed Courses (only for authenticated students)
- Courses
- Support
- News
[x] If the results return more then 3 Courses and more than 5 itens in Support and News groups, should be presented a link with "more results" that will redirect to a page with all results of the group
[x] change placehold of search input for "Search SeLI Platform"
[x] change search button label for "Search"
[x] remove from main page the search input, because already has one in the banner

Course Search

demo current page

On "SELI Courses" user can search, filter and sort the listed courses.

[x] Sort by
- Alphabetic (default)
- Most Recent
- Relevant
- most subscribed
- in case of a search query, follows specific relevance rule
[x] Search Input: System will return courses that match the query in
- Title
- Subtitle
- Keywords
[x] The courses will be presented ordered by more relevant results, ordering by
- Results that match in Title
- Results that match in Subtitle
- Results that match in keywords
[x] Filter options:
- Delivery: 100% Online or Blended
- Language
- Learning Outputs (skills)
- Duration
- Audience
- Reviews: 1-5 stars
- Instructors
- Course areas options in above image (coursera)
- Accessibility
- Show only fully accessible courses
- Show partially and fully accessible courses
- Cognitive disability
  - Show only fully accessible courses
  - Show partially and fully accessible courses
- Hearing disability
  - Show only fully accessible courses
  - Show partially and fully accessible courses
- Visual disability
  - Show only fully accessible courses
  - Show partially and fully accessible courses

Course area options:

Documentation Search When documentation page is ready, need to create a search feature.

Help Search When Help Center page is ready, need to create a search feature.

Accessibility

Follows WAI-ARIA Practice for custom components
Follows DESIGN NOTES
[x] #51
[ ] #49
[ ] #76
[ ] #167
[x] #128
[x] #114
[ ] #135
[x] #137
[x] #132
[x] #130
[x] #129
[ ] #128
[x] #127
[x] #126
[ ] #120
[ ] #119
[x] #118
[ ] #116
[x] #115
[x] #113
[ ] #112
[ ] #111
[x] #110
[ ] #101
[x] #100
[x] #99
[x] #97
[ ] #93
[ ] #92
[x] #81
[ ] #16
[ ] #77
[x] #78
[x] #80
[x] #87
[x] #85
[x] #90
[x] #62
[x] #54
Wireframes

Course search (SELI Courses page)

Filter's dialog

opened accordions

Resposive

medium

small

Platform search

github-actions[bot] commented 4 years ago

This Feature Request was accepted, but are not going to be implemented in next release.

ecureuill commented 4 years ago

~~- [ ] Platform Search and Course Search are not the same functionality. Please review the specification. For instance, in Course Search there is no requirement about grouping results.~~

It shouldn't be the same functionality, but because of the timing we decided it's ok to keep it that way

ecureuill commented 4 years ago

Filtering in Course Search is returning wrong courses. I will describe some scenarios, but you need to review all conditions.

[x] If ìnput search === ", courses returned duplicated (Image 1) Image 1
[x] When user click the search button, the query is ignoring any filter that is already applied but keeping the filters activated in GUI (Image 2). Must reset filters on every new search queries (search button is clicked)

image 2a: Filtering course by 100% Online

image 2b: After Filtering course by 100% Online, user clicked in Search button, it returned all courses without applying the filter, but still shows the "100% Online" filter as activated

[ ] Filtering by instructors is returning wrong course. Regardless of my choice, always return course where I'm the author. Probably is passing the wrong variable to the query.

[ ] The search query should be building using AND (example in sql notation)

SEARCH * 
WHERE 
title LIKE 'programing' AND 
modality = 'online' AND
language = 'portuguese'
instructor = 'camilla'

Some specifics case

[ ] The search query should be build using
IN for language, if user select more the one
IN for instructor, if user select more the one

BETWEEN for duration

SEARCH * 
WHERE 
title LIKE 'programing' AND 
modality = 'online' AND
language IN ('portuguese', 'english') AND
instructor IN ('andres', 'camilla') AND
duration BETWEEN 5 AND 100

For the next examples, I'm assuming that bellow values are the percentual of accessibility 0: inaccessible 50: partial 100: accessible

Fully accessible course

SEARCH * 
WHERE 
cognitive = 100 AND 
hearing = 100 AND
visual = 100

Show only partially and fully accessible courses

SEARCH * 
WHERE 
cognitive >= 50 AND 
hearing >= 50 AND
visual >=50

Show only fully Cognitive accessible courses, Show partially and fully Hearing accessible courses, Show all courses, even Visual inaccessible courses
```
SEARCH * 
WHERE 
cognitive = 100 AND 
hearing >= 50
```

ecureuill commented 4 years ago

[ ] Filters options that is presented in the toolbar are like shortcut for the correspondent filters in "More filters" dialog, thus if user activate or deactivate any of them, they should be presented the same away
Fully Accessible filter is the same as Show only fully accessible courses
100% online filter is the same as Show only 100% online
Stars filter

Toolbar shortcut

More filters dialog's correspondent options

github-actions[bot] commented 4 years ago

Functional Test failed! Please, review your solution.

ecureuill commented 4 years ago

Please, move to CODED only when this feature is fully implemented: bugs reported in comments and requirements in OP If you want that we test some partial solution, add a comment here with our @

github-actions[bot] commented 4 years ago

This feature have been implemented and is ready for Funcional Test. Please, test the feature.

github-actions[bot] commented 4 years ago

Functional Test failed! Please, review your solution.

user should be able to use the search bar by typing and then pressing enter.

[x] when user presses enter the system is redirecting them to the home page

[x] For this bar enter does nothing

github-actions[bot] commented 4 years ago

This feature have been implemented and is ready for Funcional Test. Please, test the feature.

github-actions[bot] commented 4 years ago

Functional Test failed! Please, review your solution.

There are still tasks to be done in the requirement, including the accessibility ones, and also those in the comments.

[ ] Course cards should not be buttons

[x] Buttons focus emphasis are not being shown when hovering with mouse, only in keyboard navigation

[x] "Course preview" button has no focus emphasis

[x] Page is inaccessible for users that need screen readers. For example, modals to unsubscribe from courses are not being read, buttons are being read as something different than what their text says buttons are being read wrong because of wrong aria-labels:

[x] In filters, the duration is not read as time format by the screen reader

[ ] Page is inaccessible for users that need to use the keyboard for navigation (~~For example, everytime the user changes the star rating filter, the focus goes back to the search bar)~~

[ ] There's no page title (this is an issue for the entire website)

[x] Default duration is shown as hh:mm:ss, as is the information tip about it, but the user can not manually enter the seconds in the field.
[x] It's impossible for the user to enter a 3 digits hour value