search

solgenomics / BrAPI-Pedigree-Viewer

7 stars 4 forks source link

Version Not Defined in PedigreeViewer.js #10

Open HMS17 opened 2 years ago

HMS17 commented 2 years ago

Utilizing the latest commit of BrAPI-Pedigree-Viewer (as opposed to pulling from NPM) results in a version is not defined error.

It seems the PedigreeViewer.js in BrAPI-Pedigree-Viewer is out of sync with the version on sgn. The BrAPI-Pedigree-Viewer received the update to retrieve parent nodes differently depending on BrAPI version but the version is not passed in.

PedigreeViewer.js?fda6:147 Uncaught (in promise) ReferenceError: version is not defined
    at eval (PedigreeViewer.js?fda6:147:1)
    at eval (BrAPI.js?f10b:833:1)
    at eval (BrAPI.js?f10b:675:1)
    at Array.forEach (<anonymous>)
    at Filter_Node.publishResult (BrAPI.js?f10b:674:1)
    at eval (BrAPI.js?f10b:805:1)
    at eval (BrAPI.js?f10b:675:1)
    at Array.forEach (<anonymous>)
    at Join_Node.publishResult (BrAPI.js?f10b:674:1)
    at eval (BrAPI.js?f10b:900:1)
MFlores2021 commented 2 years ago

I just submitted a pull request. @HMS17 You can try the branch topic/fix_brapi_version After that will push to npm