Can we associate stockprops to accessions on the pedigree viewer tool.

solgenomics / sgn

The code behind the Sol Genomics Network, Cassavabase and other Breedbase websites

https://solgenomics.net

MIT License

66 stars 35 forks source link

Can we associate stockprops to accessions on the pedigree viewer tool. #1615

Closed aco46 closed 5 years ago

aco46 commented 6 years ago

Expected Behavior

It would be useful to show some stockprops for a particular accession on the pedigree Viewer. Example maybe year of development, ploidy_level, etc.

Requested by Agre.

For Bugs:

Environment

Steps to Reproduce

bauchetg commented 6 years ago

Other good use cases would be populations, in case of very large set of progenies, hard to visualize, they could grouped by existing associated population, as here:

Population names could show next to purple arrows are. Other key stockprop being marker alleles

dauglyon commented 6 years ago

Because there is not currently a BrAPI call which will let us do this, I am going to close this issue. However, trait overlays (from observations) will be available. It may also be possible to add overlays which use other data returned in the germplasm object.

dauglyon commented 6 years ago

@bauchetg We may be able to impliment this using germplasm attributes.

dauglyon commented 6 years ago

Yes, it looks like I missed this the first go around. Germplasm Attributes should work to let us do this, it looks like our current BrAPI implementation is already giving some stockprops as attributes.

dauglyon commented 5 years ago

This can be done using the changes in https://github.com/solgenomics/BrAPI-Pedigree-Viewer/commit/ae07ae28a5f0ab0a7efcfbe550071b783541d23d and is basically a duplicate of #1501 but covering different "traits"