search

solgenomics / sgn

The code behind the Sol Genomics Network, Cassavabase and other Breedbase websites
https://solgenomics.net
MIT License
66 stars 35 forks source link

upgrade jQuery and bootstrap #3303

Open isaak opened 3 years ago

isaak commented 3 years ago

Bootstrap upgrade from 3.x to 5.x is major. It is better done by someone who knows it good and implemented it extensively.

There is a branch here: https://github.com/solgenomics/sgn/tree/topic/upgrade-jquery-bootstrap

ClayBirkett commented 3 years ago

Is it possible to upgrade to a new version of jQuery incrementally (page by page)? It seems too big of a project to upgrade all the code at once to use new jQuery. Another alternative would be to schedule a hackathon to work on this for a few days.

ClayBirkett commented 2 years ago

Here are pages with upgrade notes https://jquery.com/upgrade-guide/1.9/ https://jquery.com/upgrade-guide/3.0/

I found the following important changes jQuery 1.9 deprecated the .attr() in most cases jQuery 3 changed the jqXHR return from jQuery.ajax(), replace (success, error, complete) with (done, fail, always) or use then catch methods

lukasmueller commented 6 months ago

Maybe split this in two?