search

solgenomics / sgn

The code behind the Sol Genomics Network, Cassavabase and other Breedbase websites
https://solgenomics.net
MIT License
67 stars 35 forks source link

Search Wizard: Genotyping Projects are included in Trials #3436

Open dwaring87 opened 3 years ago

dwaring87 commented 3 years ago

Expected Behavior

In the Search Wizard, a Genotyping Project is listed in both the Genotyping Project category as well as the Trial category.

Example: on Cassavabase the "Farmer preferences genotyping project" is listed in both.

I would expect only phenotyping trials to be listed as "Trials".

For Bugs:

Environment

Steps to Reproduce

dwaring87 commented 3 years ago

The query for the trials matview seems to include all projects except those of types: cross, trial_folder, folder_for_trials, folder_for_crosses

lukasmueller commented 2 years ago

Has this issue been fixed?

dwaring87 commented 2 years ago

@lukasmueller The issue still exists, but I don't remember if it was decided if this was a "feature" or a "bug"

bellerbrock commented 2 years ago

Causes #3860, so this is looking a lot more like a bug

Like David said a bunch of non-field trial project categories ('cross', 'trial_folder', 'folder_for_trials, 'folder_for_crosses', 'folder_for_genotyping_trials') are filtered out in the trials view definition, but not all of them. Part of the problem is the view has to be updated everytime a new category is added

A better solution would be to postively identify all field trials with a phenotyping_trial projectprop. Then the filter would only have to check a single prop, and would be a lot more futureproof.