solgenomics / sgn

The code behind the Sol Genomics Network, Cassavabase and other Breedbase websites
https://solgenomics.net
MIT License
66 stars 35 forks source link

Refactor project_type, project_property, and experiment_type cvs #3861

Open bellerbrock opened 2 years ago

bellerbrock commented 2 years ago

Expected Behavior

The existing terms are confusing.

The current state of the 3 cvs in a typical database:

cv.name cvterm.name
project_property breeding_program
project_property folder_for_crosses
project_property folder_for_genotyping_trials
project_property folder_for_trials
project_property trial_folder
------------- -------------
project_type Advanced Yield Trial
project_type Clonal Evaluation
project_type crossing_block_trial
project_type crossing_trial
project_type genetic_gain_trial
project_type genotyping_trial
project_type grafting_trial
project_type health_status_trial
project_type heterosis_trial
project_type misc_trial
project_type phenotyping_trial
project_type pollinating_trial
project_type Preliminary Yield Trial
project_type Regional Trials
project_type Screen House
project_type Seedling Nursery
project_type Seed Multiplication
project_type Specialty Trial
project_type storage_trial
project_type Uniform Yield Trial
project_type Variety Release Trial
------------- -------------
experiment_type analysis_experiment
experiment_type analysis_model_experiment
experiment_type analytics_protocol_experiment
experiment_type cross_experiment
experiment_type drone_run_experiment
experiment_type field_layout
experiment_type genotyping_experiment
experiment_type genotyping_layout
experiment_type grafting_experiment
experiment_type pedigree experiment
experiment_type phenotyping_experiment
experiment_type sampling_layout
experiment_type seedlot_experiment
experiment_type trained_keras_cnn_model_experiment
experiment_type treatment_experiment

For Bugs:

Environment

Steps to Reproduce

nmenda commented 2 years ago

@bellerbrock it looks to me like experiment_type and the above project_property cvterms be changed to cv= project_type

titima15 commented 2 years ago

Hi @nmenda @bellerbrock , I think crossing_trial project_type and cross_experiment experiment_type have correct cv. Could you please don't change cv of these two cvterms? Thanks

titima15 commented 2 years ago

A few other experiment_type cvterms in that list are used in the nd_experiment

nmenda commented 1 year ago
  1. Need to write dbpatch to populate project.type_id from projectprop
  2. modify code to use project.type_id, such as manage pages should show projects depending on type_id
  3. Every type of project creation needs to populate project.type_id correctly
titima15 commented 1 year ago

@nmenda @lukasmueller I think we should use the terms genotyping_plate (not genotyping_trial), genotyping_project (not genotyping_data_project), crossing_experiment (not crossing_trial), because these terms are now well established and clearer.