Open lukasmueller opened 2 years ago
@nickmorales, @jmh579 it looks like this functionality used to exist, but was removed. Was there a reason to restrict uploads to samples only that we are missing?
, @
@bellerbrock I think that it was changed because you can have scans from multiple different tissues per plot, each tissue will give a different spectral pattern. With plot-level data, it isn't clear which tissue was scanned. This could lead to the averaging of scans from different tissues, which we don't want.
There might be a better way to specify tissue type within the high dimensional phenotype storage itself to avoid having to create a bunch of different tissue samples within the database. I can bring it up with the BrAPI High Dimensional Phenotypes group on Friday. I'll send you a slack message with the meeting info in case you want to join.
Thanks @jmh579 . Per the discussion today in the high-dimensional phenotypes weekly meeting:
Proposed solution: Let users use plot/plant ids in their upload file. But have them select the relevant tissue in a dropdown, and create a sampling trial and tissue sample ids in the background during the upload.
@bellerbrock I like that idea, can you implement it?
Working on this now. Another scenario to make sure to address - cases where technical replicates (many spectra collected on the same processed sample) are included in the nirs upload
Has this been implemented? If so, we should close the ticket.
Expected Behavior
For Bugs:
Environment
Steps to Reproduce