Open chris263 opened 1 week ago
bellerbrock
commented
1 week ago Related to #4828 which outlines some fixes needed to make the current pedigree string implementation fully match Purdy notation
@chris263 what does the program you're working with expect for pedigree notation? The example string is ugly but I think expected for Purdy notation,. It just looks like their conventions may be incompatible with Purdy since they have / and ( in their accession names.
chris263
commented
1 week ago The pedigree view looks fine. What they expect is to pass the same information (just 1 parent if the cross is self) to the field book app.
They have a very complex naming convention. However, it is pretty consolidated in the company (actually, it is used for more than than one company in many countries). Here are the symbols they are using: <!DOCTYPE html>
| Character | Description |
|---|---|
| / | 50% each parent |
| . | 25.00% |
| + | 12.50% |
| : | 6.25% |
| ) | Ear selection method |
| X | Self pollination in bulk |
| @@ | Double haploid |
Here is an example: A015.A105/E038.A038)X2B3
bellerbrock
commented
3 days ago Ah, ok, good details. Purdy was developed with wheat if I'm remembering correctly, sounds like this system is more specific to corn? Does it have a name?
If it's implemented alongside purdy notation and the existing options for pedigree string, then I like the idea you mentioned of setting the default pedigree string format in the conf file. That way everyone should be able to get the version they expect in Field Book as long as the BrAPI germplasm endpoint returns the default string.
If they need access to multiple version of the string then it will be important to update the BrAPI spec: https://github.com/plantbreeding/BrAPI/issues/589
Expected Behavior
Pedigree view is showing only one name as parent when the pedigree comes from a self. It also would be transfered to field book app. Expected results: 1 - Transfer only one name as parent to field book if the crossing type is "self". 2 - Make this configuration available in sgn_local.conf. (I believe, some breeding programs still want to see two parental names).
For Bugs:
Environment
Steps to Reproduce