solgenomics / sgn

The code behind the Sol Genomics Network, Cassavabase and other Breedbase websites
https://solgenomics.net
MIT License
66 stars 35 forks source link

CitrusBase - Issues with format of Trait File for FieldBook import. #4993

Open hkmanching opened 2 months ago

hkmanching commented 2 months ago

Expected Behavior

When creating and downloading a trait file for use in fieldbook in Citrusbase, I expect the details column to include the trait definition for each trait and for the trait name to be formatted as "trait name|trait id" (no appended [CIT] to name).

Actual Behavior (see attached file from CitrusBase.)

The trait column in the trait file is formatted as "trait name [CIT] (large space/multiple tabs)|trait id".

The details column has mostly just the "trait name [CIT]" but sometimes has "trait name [CIT] and description," but description is on the next line and is not included when uploaded to Fieldbook (see trait: CtDnMajVol in file).


For Bugs:

Environment

CitrusBase

Steps to Reproduce

  1. Navigate to Manage --> Field Book App
  2. Select "NEW" under Trait Files
  3. Select the trait list AllTraits_20240701.
  4. Download once file is created.
  5. Upload to FieldBook via import file functionality. ActualBehavior2024-07-01_19_48_42_All.txt ExpectedBehavior2024-07-01_19_48_42.txt
hkmanching commented 2 months ago

There are also a bunch of other errors with the traits that are currently in CitrusBase, but not sure if I should include that here or schedule some time to talk to you guys about it.