solgenomics / sgn

The code behind the Sol Genomics Network, Cassavabase and other Breedbase websites
https://solgenomics.net
MIT License
66 stars 35 forks source link

Phenotype Download: Include plots with missing data #5084

Closed dwaring87 closed 1 week ago

dwaring87 commented 2 weeks ago

Expected Behavior

When downloading phenotype data (from the Search Wizard or the Trial Detail Page), if no traits are selected, then all plots are included in the download (even if there is no recorded observation for a particular plot). However, if a trait is selected, then only the plots with a value for that trait are included. It's been requested by breeders that plots with missing data are included as well.

For Bugs:

Environment

Steps to Reproduce

dwaring87 commented 2 weeks ago

This seems to be a problem just with the Native download. The MatView download will include all of the plots, regardless of trait values.