search

solgenomics / sgn

The code behind the Sol Genomics Network, Cassavabase and other Breedbase websites
https://solgenomics.net
MIT License
66 stars 35 forks source link

Multi-Trial Upload: fails with location codes #5129

Open dwaring87 opened 1 month ago

dwaring87 commented 1 month ago

Expected Behavior

This earlier PR added the ability to use the location abbreviation/code instead of the full name for the location in the multi-trial upload.

The upload now silently fails (says the trials were added successfully but are not added to the database) if one or more trials use the location abbreviation/code in the location column. The upload plugin correctly validates the location code, but the additional location check in the upload_multiple_trial_design.pl script fails.

It might be a good idea to remove the location check in the perl script, since it's already being done by the plugin validation.

For Bugs:

Environment

Steps to Reproduce

dwaring87 commented 1 month ago

The upload plugin is correctly replacing the location codes with the correct location name and returning that in the parsed data. However, the perl script is re-reading the original file and not using the parsed data from the plugin.