Before
Organization model, controller, and serializer were slightly out of date with current usage
After
added default_scope ordering to ensure stable ordering in responses
adjusted serializer to include dashboards and use conventional serialization method
removed non-RESTful org_role methods and routes from Organization controller and routes
changed org_role dependency callback to the safer destroy method
Notes
We don't currently use the org_role routes and opt for an invitation strategy instead. Future re-implentation of similar routes should use RESTful routing conventions such as nested resource routing
API serialization changes are non-breaking because they maintain currently used API response formats
Tested against the current main branch of trivial-ui
Before Organization model, controller, and serializer were slightly out of date with current usage
After
default_scopeordering to ensure stable ordering in responsesdashboardsand use conventional serialization methodorg_rolemethods and routes fromOrganizationcontroller and routesorg_roledependency callback to the saferdestroymethodNotes
org_roleroutes and opt for an invitation strategy instead. Future re-implentation of similar routes should use RESTful routing conventions such as nested resource routingmainbranch oftrivial-ui