search

solid-contrib / solid-auth-fetcher

A client library for authenticating with Solid
Other
2 stars 7 forks source link

Fix login options declaration mix-up #20

Closed NoelDeMartin closed 8 months ago

NoelDeMartin commented 3 years ago

This is a silly fix, but it can potentially break existing applications relying on types. So maybe this should be held up until a release with other breaking changes.

josephguillaume commented 3 years ago

To be specific, the types for IIssuerLoginInputOptions and IWebIdLoginInputOptions were inverted. The types are exported, but internally they are only ever used to define ILoginInputOptions, so it seems unlikely others would also be depending on this type. https://github.com/solid/solid-auth-fetcher/blob/1407fb9dacdfa8bf0cd31f397161ae27ce980704/src/ILoginInputOptions.ts#L26-L30

While the breaking change could perhaps be mentioned in a news/changelog file, it's probably safe to merge this otherwise.