search

solid-contrib / solid-node-client

a nodejs client for Solid
MIT License
20 stars 8 forks source link

Catching and throwing an exception when not a trusted app #13

Open javiergarber opened 3 years ago

javiergarber commented 3 years ago

Hi, I'm doing a node app with the library, and there is no way of catching the exception thrown when the app is not added as "trusted application". You should consider catching the exception when using the solid-auth-fetcher and throwing a new exception when using the "login" method, for the users of the library to handle it. Thank you in advance

jeff-zucker commented 3 years ago

Thanks much for your suggestion. I am looking at ways of not requiring the trusatedApp setting. If I can get that working, it won't be a problem since you won't have to set trustedApp at all. If I can't, I'll follow your suggestion and give a warning.

javiergarber commented 3 years ago

Thank you so much, looking forward see your discoveries!